update spec

spec/todo-12-18-2020.txt

@@ -1,16 +1,41 @@
 
 	dev.hr.leadershiphealth.org
+	
+		@Josh
+		https://dev.pro.leadershiphealth.org/confirm_password
+		
+			This is terrible. "Confirm password" is not a thing!
+			
+			Change to simply:
+			
+			Hello, Sal! (okay because they have authenticated their token anyway).
+			
+			Please enter your password to continue.
+			
+			Also, change URL to NEVER EVER have underscores ever.
+			
+			@Aftab->Samson
+			design better according to proper layout of design theme overall that is needed.
+			
+		@Josh
+			On this "confirm password" page which you rename to just "password"
+			what if they don't remember their password? They need to be able to reset their password.
+			Or they need some help text to know what to do!
 
 		/ (HOMEPAGE)
 
+			@Sal @Aftab
 			* modify text and layout, make it look better / different than DialMD.com
 
 		/confirm-auth-token
 
+			@Samson
 			* still says "DialMD.com HR"
 
+			@Sal/Aftab
 			* add better text / layout to confirm token
 
+			@Samson
 			* show the number against which they are getting the token:
 
 				We sent a token to your number: 888-888-888
@@ -22,78 +47,134 @@
 
 		/pro-details
 
+			@Josh
 			* modify this URL to "account-setup"
 
+			@Sal
 			* proper welcome paragraph
 
+			@Aftab
 			* better layout
 
-			*** email address is not verified... later they should be asked to verify their email.
+			@Josh
+				*** email address is not verified... later they should be asked to verify their email.
+				
+				!!!!!!! BIG PROBLEM.
+				
+				Email address is already in use.
+				Do not ever show them other users. Privacy problem.
+				Just accept the email quietly and LATER ask them to verify their email address.
+				This is when the true owner of the email can get upset or not.
+					"Hey, someone asked to use your email. Was this you? You're already a pro."
 
+<<<<<<< HEAD
 				*** Later, this needs to be confirmed / locked by admin level pros.
 
 			*** send them a welcome email now that they have created an account here.
+=======
+				*** send them a welcome email now that they have created an account here.
+				
+				*** send them a confirmation text.
+>>>>>>> 9cb457d5eb0f935ccc414043930dc07203341e1f
 
 		/set_security_questions
 
-			* modify this URL to not have underscore
+			@Vijay
+				* modify this URL to not have underscore
 
-			* needs better layout
+			@Aftab
+				* needs better layout
 
-			* add more security questions, including "write your own"
+			@Vijay
+				* add more security questions, including "write your own"
 
 		/ (LOGGED IN!)
 		
-			* needs proper layout
+			@Aftab @Sal
+				* needs proper layout
+				* "Login to credo" does not make sense... it needs to be explicitly clear to someone that this is their HR portal.
 			
+<<<<<<< HEAD
 			* "Login to credo" does not make sense... it needs to be explicitly clear to someone that this is their HR portal.
 			
 			* ??? We think @Vijay has modified this page to support updating profile and @Samson supported self-changing password
 				this is probably not the latest.
 			
 			* If they have NO AppAccess at all.... auto log them into Credo.
+=======
+			@Josh
+			* ??? @Vijay has modified this page to support updating profile...
+				??? Nobody has yet supported self-changing password - @Josh please do it. -> then assign to @Vijay to style.
+>>>>>>> 9cb457d5eb0f935ccc414043930dc07203341e1f
 		
 ---------------------------------------------------------------------------------------------------------------
 	
 	@Josh
 	dev.credentialing.leadershiphealth.org *****PROBLEM::: FIX URL to this, not scholarhealth!
 			
+		@Aftab
+			layout is off - no need for top nav if only one "HOME" for example.
+				Logo
+				Top Navbar
+			
 		/welcome
 		
+<<<<<<< HEAD
 			* welcome screen is off. @Samson is going to mimic DialMD flow.
+=======
+			@Samson
+			* welcome screen is off. Mimic DialMD welcome. -> Assign to Sal to modify slightly.
+>>>>>>> 9cb457d5eb0f935ccc414043930dc07203341e1f
 			
 		/basic-info
 			
+			@Samson - don't create weird variables / call them as objects.
 			* BROKEN - BLOCKED
 				
-		/profession @Muhammad
+		/profession 
 			
 			* Should be defaulted to a simple screen:
 				
+				@Samson - Don't default to anything!
 				Are you a healthcare professional?
+					[Yes] [No]
 				
-				What type:
-				
-					[Physician]
-					[Physician Assistant]
-					[Nurse Practitioner]
-					[Registered Dietitian]
-					etc.
+				If(Yes)
+					@Muhammad - give Samson all the types
+					What type:
+					
+						[Physician]
+						[Physician Assistant]
+						[Nurse Practitioner]
+						[Registered Dietitian]
+						etc.
+						
+				If(No)
+					...
 		
-			* needs conditional display of non-hcp fields.
+			* Needs conditional display of non-hcp fields.
 			
-			*** @Muhammad Create detailed way to capture previous and future career interests.
+			---@Sal verify that we have all fields needed.
 		
 		/hours-of-availability
 		
+<<<<<<< HEAD
 			* Please tell us about your general hours of availability. 
 			This is a free text field so that you can get as specific as you want with regards to availability. 
 			This helps your onboarding specialist connect you with the correct patient panel that fits your schedule.
 			
 				*** MODIFY THIS TEXT to not say "correct patient panel" unless they are a healtchare pro. 
 				It should instead then say "a position that appropriately fits your schedule."
+=======
+			@Samson
+			* Please tell us about your general hours of availability. This is a free text field so that you can get as specific as you want with regards to availability. This helps your onboarding specialist connect you with the correct patient panel that fits your schedule.
+>>>>>>> 9cb457d5eb0f935ccc414043930dc07203341e1f
 		
+				@Samson
+					*** MODIFY THIS TEXT to not say "correct patient panel" unless they are a healtchare pro. It should instead then say "a position that appropriately fits your schedule."
+
 		/webcam-check
+<<<<<<< HEAD
 		
 			* introduce same welcome paragraph and welcome video for LeadershipHealth HR at the top.
 				
@@ -104,24 +185,52 @@
 			@Josh
 			* this page seems extremely buggy - please fix it - don't let a button spin etc. unless video.
 		
+=======
+
+			@Josh/Samson
+				100% Mimic the DialMD page 100% even with same Wistia video embedded. We will later swap videos.
+
+				* introduce same welcome paragraph and welcome video for LeadershipHealth HR at the top.	
+					@TODO Get a video made.
+
+				* don't provide a submit button unless it is truly submittable.
+
+				* this page seems extremely buggy - please fix it - don't let a button spin etc. unless video.
+
+		@Josh
+>>>>>>> 9cb457d5eb0f935ccc414043930dc07203341e1f
 		/resume
-		
+
 			* BROKEN! BLOCKED! Does not work.
+<<<<<<< HEAD
+=======
+			
+			@Josh/Vijay...> let them view it once uploaded.
+				If MSWord -> convert to PDF and show.
+>>>>>>> 9cb457d5eb0f935ccc414043930dc07203341e1f
 
 ---------------------------------------------------------------------------------------------------------------
 
 	AGENT view of Credo
 
-		* IID needs to be fixed, only need 6 digits.
+		@Josh
+		* IID needs to be fixed, only need 3 letters + 3 digits.
+		
+		@Samson, change all web routes from uid to iid for prettier URLs
 
 		/ (HOME DASHBOARD)
 
+			@Muhammad
 			* TODO There is nothing here right now. What are the vital statistics?
 
 		/agents
+		
+			@Muhammad
+				What columns need to go here?
 
 		TODO @Muhammad, systematically document EVERY THING that needs to be fixed / changed.
 		
+<<<<<<< HEAD
 		!!! /settings APPROVAL is HTML vomit. 
 		
 			- It needs to be better positioned.
@@ -135,18 +244,31 @@
 				Someone can't say they are not an HCP, we approve them and give them a contract,
 				THEN on their dashboard they change their "profession" section to say they are an HCP,
 				and because they're already approved they end up seeing all the stuff an approved HCP sees.
+=======
+		@Samson
+			!!! /settings APPROVAL is HTML vomit. Style as a separate card.
+				- It needs to be "professional_status: APPLIED, ONBOARDING, ONBOARDED, CANCELED" not just 'approved'
+>>>>>>> 9cb457d5eb0f935ccc414043930dc07203341e1f
 			
-		!!! AGENTS NEED ALL DATA REGARDING welcome to webcam-check etc. steps on professional single record page.
-			
-			Only then they know whether to approve or not.
+				- ALSO, we need other things depending on whether or not they are an HCP.
+				
+					@Samson (Josh help)
+						https://dev.credentialing.scholarhealth.com/pro/view/welcome accessible despite status != applied...
+						create middleware to block old URLs for when they were in application mode.
+
+						Someone can't say they are not an HCP, we approve them and give them a contract,
+						THEN on their dashboard they change their "profession" section to say they are an HCP,
+						and because they're already approved they end up seeing all the stuff an approved HCP sees.
 			
-		@@@ We need an entity for agents to document phone calls and memos.
-		
-		@@@ We should connect Twilio for agents so that all calls are recorded and playable.
+		@Samson
+			!!! AGENTS NEED ALL DATA REGARDING welcome to webcam-check etc. steps on professional single record page.
+				Only then they know whether to approve or not.
 		
-		@@@ Add click to dial for agents.
-		
-		@@@ Add click to email candidate.
+		@Josh
+			@@@ We need an entity for agents to document phone calls and memos.
+			@@@ We should connect Twilio for agents so that all calls are recorded and playable.
+			@@@ Add click to dial for agents.
+			@@@ Add click to email candidate.
 
 ---------------------------------------------------------------------------------------------------------------
 
@@ -154,54 +276,84 @@
 	
 		@@@ TODO::: There needs to be a EXTREMELY CLEAR focus towards the user 100% following the flow for onboarding.
 		
-			Right now, we have way too much stuff everywhere.
-			
-				It needs to be: 
+			@Muhammad/Sal -> Aftab
+
+				Right now, we have way too much stuff everywhere.
 				
-					1. Basic Information
-					2. Resume
-					3. Offer Letter
-						! ABC
-					4. Etc.
-					5.
+					It needs to be a wizars: 
 					
-				With a list of pending problems scoped within that numbered point.
-				
-				That way we can tell them clearly: "You have a problem on Step 3."
+						1. Basic Information
+						2. Resume
+						3. Offer Letter
+							! ABC
+						4. Etc.
+						
+					With a list of pending problems scoped within that numbered point.
+
+					That way we can tell them clearly: "You have a problem on Step 3."
 				
-		UI needs to be optimized for the idea that they will have ONE contract. But if they have more than 1, it's fine, just show a list of their contracts and then they can choose which to view just like any single-record page.
+			***NOTE***
+			UI needs to be optimized for the idea that they will have ONE contract. But if they have more than 1, it's fine, just show a list of their contracts and then they can choose which to view just like any single-record page.
+			
+		@Josh...
+			make it simple to add pro_rate to pros on FE like this...
+					RM20
+				MCP 10
+				RMM 15
+				RME 30
 	
 ---------------------------------------------------------------------------------------------------------------
 			
+<<<<<<< HEAD
 	!!! IMPORTANTLY, the Offer Letter / Legal Contract / NDA / whatever need better statuses.
 		
 		Not YES/NO but instead COMPLETED, PENDING, DECLINED.
 
 		@@@URGENT FEATURE::: support internal signature via "DocuSign" internally.
+=======
+	@Samson
+	
+		Contracts can be PENDING, COMPLETED, CANCELED.
+			
+	@Samson - each contract has multiple signable documents.
+
+		!!! IMPORTANTLY, the Offer Letter / Legal Contract / NDA / whatever need better statuses.
+>>>>>>> 9cb457d5eb0f935ccc414043930dc07203341e1f
 		
+		Not YES/NO but instead PENDING, SENT, SIGNED, CANCELED
+	
+	@Muhammad->Samson
 	!!! IMPORTANTLY, they need to go to DIFFERENT VIEWS depending on if they're an HCP or not.
 	
 		For example, only HCP needs to worry about most sections like:
 			Self Malpractice
 			State Licenses
 			Etc.
+			
+		Non-HCP needs to focus on just contract document signing.
 
 -------------------------------------------------------------------------------------------------------------------
 
 	@Josh
 	@@@ Change "My Apps" label on Credo to "Exit" which takes you out of Credo and back to Stag.
 
+		@Samson
 		* Exit from this app rather than log out from the entire system.
 
 -------------------------------------------------------------------------------------------------------------------
 
+<<<<<<< HEAD
 	@Vijay
+=======
+	@Josh/Vijay for pro
+>>>>>>> 9cb457d5eb0f935ccc414043930dc07203341e1f
 	ADMIN PORTAL: profileImageFile:must not be null
 
 -------------------------------------------------------------------------------------------------------------------
 
 	https://dev.leadershiphealth.org/pro/sal-test
 	
+<<<<<<< HEAD
 		* Update text to something more decent.
 			
 			COVID-19 is a problem.
@@ -211,28 +363,56 @@
 		
 		@Josh
 		* @You are already registered. Please login. !!! WRONG !!!
+=======
+		@Sal
+			* Update text to something more decent.
+				
+				COVID-19 is a problem.
+				Here is some important stuff to get set up.
+				*** Watch this video.
+				Susan Lee -> Dynamic name. & profile picture.
+>>>>>>> 9cb457d5eb0f935ccc414043930dc07203341e1f
 		
-			DONKEY SYSTEM. Send them an email telling them "Hey you already have an account."
+		@Josh - !!! PRIVACY ISSUE !!!
+			* @You are already registered. Please login. !!! WRONG !!!	
+				DONKEY SYSTEM. Send them an email telling them "Hey you already have an account."
 			
 		@Josh
+<<<<<<< HEAD
 		* Prevent +1@gmail.com emails in production.
+=======
+			* Prevent +x@gmail.com emails in production.
+>>>>>>> 9cb457d5eb0f935ccc414043930dc07203341e1f
 		
+		@Josh
 		* Email for "Welcome" -> is terrible. Also, uses the wrong URL.
 			https://fe6.endochannel.com/confirm-email/B6g6IqTD2iQP
 			
 			What is the correct domain? dev.leadershiphealth.org
+			
+			@Aftab
+			HTML of the welcome email
 
 -------------------------------------------------------------------------------------------------------------------
 
 	https://dev.leadershiphealth.org/my-dashboard
 	
-		* Show the face of who you are signing up with and what you are signing up for.
+		@Sal
+		* Show the face of who you are signing up with and what you are signing up for. (show "cart" while checkout)
+		"You're minutes away from seeing ___ and getting a free COVID-19 safety kit."
 			
+<<<<<<< HEAD
 			* DIES QUIETLY when I enter 999999999A
 			but on network, it says "MCN is invalid"
+=======
+		@Josh
+			* AJAX DIES QUIETLY when I enter 999999999A... no ui feedback.
+>>>>>>> 9cb457d5eb0f935ccc414043930dc07203341e1f
 			
+		@Aftab
 		* When I enter 333333333A, this screen: You are eligible! This is address we have on file from Medicare:
 			
+<<<<<<< HEAD
 			Needs to be better thought out / designed.
 			
 			Needs to properly explain to them what is going on.
@@ -240,10 +420,18 @@
 			Here's the address on file.
 			
 		* Logout button next to Welcome panel looks like it's the "Next Step" icon... 
+=======
+			@Aftab
+			Needs to be better thought out layout. "You're eligible. Here's the address on file."
+
+		@Aftab
+			* Logout button looks like it's the "Next Step" icon... 
+>>>>>>> 9cb457d5eb0f935ccc414043930dc07203341e1f
 		
+		@Josh
 		* BLOCKER!!!!!!!!! [Proceed to Next Step] does not work.
-		
 			* Have to refresh the screen and then it works. This is bad!
+<<<<<<< HEAD
 			
 		* SECURITY ISSUE!!!!!!!!!!! Why are we seeing Muhammad Amin ??? We're showing everyone to the account.
 		
@@ -254,13 +442,29 @@
 			with [Start Video Call] button ???
 			
 			WHY IS THIS THERE ::: At the account level. Where does this checkIn token even come from?
+=======
+		
+		@Vijay/Peter
+			https://dev.leadershiphealth.org/my-dashboard
+			Change top navbar and "My Chart" you are already in!
+			Layout needs to change, with "Back to Website" link at top which takes you to standard leadershiphealth.org info site.
+>>>>>>> 9cb457d5eb0f935ccc414043930dc07203341e1f
+			
+		@Vijay
+			* SECURITY ISSUE!!!!!!!!!!! Why are we seeing Muhammad Amin ???
+			THIS ENTIRE SCREEN IS BAD - There is an update isn't there?
 			
-			Which chart is it for?
-			
-			!!! You are currently in "MY ACCOUNT" context. You're not in "MY CHART" context for a particular patient.
+			**** TERRIBLE: Why is there a "http://localhost:8004/client/checkin?checkInToken=W7JRO4DU"
 			
-		***** We need to make it explicitly clear at all times which single record chart you are involved with.
+				with [Start Video Call] button ???
+				
+				At the account level. Where does this checkIn token even come from?
+				
+				Which chart is it for?
+				
+				!!! You are currently in "MY ACCOUNT" context. You're not in "MY CHART" context for a particular patient.
 		
+<<<<<<< HEAD
 		IF YOU have entered a valid patient record - and if that chart is already on a different account, 
 			an ADMIN pro has to grant access on that "account_chart" entity.
 
@@ -269,35 +473,57 @@
 		!!! BOTTOM LINE: if you enter a valid MCN on an account, and that MCN is already linked to another account,
 		IT'S OKAY still create a account_chart record but flag it as "PENDING" and only an ADMIN type pro can release it. 
 		This could be someone fishing. ONLY THE FIRST PERSON who enters a valid MCN is auto-granted access to the patient.
+=======
+		@Peter
+			***** We need to make it explicitly clear at all times which single record chart you are involved with.
 		
-		@@@ This is crucial because in very near future, we will give evey CHART a patient view with measurements etc.
+		@Vijay
+		IF YOU have entered a valid patient record - and if that chart is already on an account, an ADMIN pro has to grant access on that "account_chart" entity.
+>>>>>>> 9cb457d5eb0f935ccc414043930dc07203341e1f
+		
+			!!! BOTTOM LINE: if you enter a valid MCN on an account, and that MCN is already linked to another account,
+			IT'S OKAY still create a account_chart record but flag it as "PENDING" and only an ADMIN type pro can release it. This could be someone fishing. ONLY THE FIRST PERSON who enters a valid MCN is auto-granted access to the patient.
+			
+				@@@ This is crucial because in very near future, we will give evey CHART a patient view with measurements etc.
 
 -------------------------------------------------------------------------------------------------------------------
 
-	@BLOCKED!!! https://dev.leadershiphealth.org/logout is broken.
+	@Josh
+		@BLOCKED!!! https://dev.leadershiphealth.org/logout is broken from the log-out on FE6.
 	
 -------------------------------------------------------------------------------------------------------------------
-	
-	https://hcp.endochannel.com/mc all these endochannel and scholarhealth links need to be removed.
+
+	@Josh
+		https://hcp.endochannel.com/mc all these endochannel and scholarhealth links need to be removed.
 	
 -------------------------------------------------------------------------------------------------------------------
 
 	!!! https://dev.manager.leadershiphealth.org/patients/pending-onboarding
 	
+<<<<<<< HEAD
 	@@@ SECURITY PROBLEM::: All the queries are bad.
 	
 	"You are assigned as the care manager." This isn't true. This doesn't look logic driven.
+=======
+	@@@ SECURITY PROBLEM::: 
+	"You are assigned as the care manager." This isn't true.
+	
+	@Vijay
+		Change to RMM || RME || MCP
+>>>>>>> 9cb457d5eb0f935ccc414043930dc07203341e1f
 
 -------------------------------------------------------------------------------------------------------------------
-
-	https://dev.manager.leadershiphealth.org/patients/view/308cc79e-3668-4c66-8efc-c05d22a6048b/health
 	
-	@@@ "As on ..." bad English -> "As of TIMESTAMP"
+	@Peter
+		@@@ "As on ..." -> "As of TIMESTAMP"
+			https://dev.manager.leadershiphealth.org/patients/view/308cc79e-3668-4c66-8efc-c05d22a6048b/health
 
 -------------------------------------------------------------------------------------------------------------------
 
-	https://dev.manager.leadershiphealth.org/index.html
-	
-	Search takes you to this which is broken.
+	@Vijay
+
+		https://dev.manager.leadershiphealth.org/index.html
+		
+		Search takes you to this which is broken.
 
 -------------------------------------------------------------------------------------------------------------------